Avx2 new algo and tests fix #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@Nick-Nuon Note that this PR is on top of #26 Merging this will not go to the main branch!!! |
|
It looks kosher , I would suggest maybe restoring the traits before merging eg on my pc, the compiler wont accept [Fact] but it will accept [Trait("Category", "avx")] as otherwise it takes away the ability to filter at runtime from the cli, but other than that its good! |
Please see my new commit which should fix this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This 'fixes' the Avx2 tests by making sure that they only run when Avx2 is available. I did nothing smart, just using the infrastructure that @Nick-Nuon had built.