Fix paging issue with tabular view #141
Conversation
Fix the problem that occurs when the previous page from the history is reapplied and the number of items has changed to something smaller than the desired page. Fixes simile-widgets#129
|
So I was working on this issue at the same time as you, which led me to a related issue involving the view rendering itself twice when it only needed to render itself once. I've pushed commits which fix both problem and, I think, make your pull request redundant. But it would be great if you could take a look and see if I missed anything. |
|
The only difference I see is my changes set the page to the last page and yours sets to the first page. My thoughts; if the user is looking at data towards the end of the dataset and they change the facet they may still be interested in that data towards the end so put the user on the last page. Ultimately both solutions prevent a blank page. |
|
I chose to set the first page because that is what people expect when they jump to an entirely new page/query, so it seemed appealing to be consistent with that. There's actually a deeper problem here that hasn't been solved yet because I'm still pondering what the right solution is. I've written some about the issue in #130 . |
Fix the problem that occurs when the previous page from the history is
reapplied and the number of items has changed to something smaller than
the desired page.
Fixes #129