fixing min/max variables bug

parsing value as float in decimalFormat() methode
simogeo · May 12, 2017 · 8941b54 · 8941b54
1 parent 9a0b715
commit 8941b54
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 24 deletions.
diff --git a/changelog b/changelog
@@ -3,6 +3,8 @@ From version 1.5.0 to 1.6.0
 - Typo bug converting string to float | issue #32
 - Force precision to 20 if user defined is superior - to prevent browser error | issue #34
 - Mean calculation outside loop | issue #35
+- Min / Max methods handled without using Math function | supposed to prevent issue #33
+- Cast values to Float on decimalFormat method | issue #36
 
 From version 1.4.0 to 1.5.0
 ---------------------------

diff --git a/lib/geostats.js b/lib/geostats.js
@@ -242,7 +242,7 @@ var geostats = function(a) {
 		for (var i = 0; i < a.length; i++) {
 			// check if the given value is a number
 			if (isNumber(a[i])) {
-				b[i] = parseFloat(a[i]).toFixed(this.precision);
+				b[i] = parseFloat(parseFloat(a[i]).toFixed(this.precision));
 			} else {
 				b[i] = a[i];
 			}
@@ -274,7 +274,7 @@ var geostats = function(a) {
 		this.stat_min = this.serie[0];
 
 		for (i = 0; i < this.pop(); i++) {
-			if (this.serie[i] < min) {
+			if (this.serie[i] < this.stat_min) {
 				this.stat_min = this.serie[i];
 			}
 		}
@@ -290,7 +290,7 @@ var geostats = function(a) {
 
 		this.stat_max = this.serie[0];
 		for (i = 0; i < this.pop(); i++) {
-			if (this.serie[i] > max) {
+			if (this.serie[i] > this.stat_max) {
 				this.stat_max = this.serie[i];
 			}
 		}