Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(re-)implement as_flights_pacakges test patch #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alex-gable
Copy link
Contributor

allows for passing as_flights_package test, without altering existing behavior, by:

  1. building the package in a temp directory, bypassing the error generated by usethis::create_package()
    • using a tmp directory causes the valid CRAN package name check to fail, so we also pass check_name = FALSE through this function to usethis::use_description()
  2. removing the assertion of an .Rproj file existing in the package directory
    • create_package uses usethis::use_rstudio(), which we want if we're creating our own copy of the package. The function tries to place an .Rproj file in the package directory, which unfortunately forces a prompt that we can't answer in the non-interactive session, failing the test.

(follow up from #15)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant