Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in calibration to reflect ones made in syslib #72

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

beringueb
Copy link
Collaborator

Changing the keys to cal_pars to reflect the fact that they are a_lm (or map) level calibraation. This is now more consistent and makes with what has been changed to syslibrary here: simonsobs/syslibrary#17

@sgiardie
Copy link
Collaborator

Looks good but we should refer to the correct version of syslibrary. Did you push this before the modifications in syslibrary were merged to the master? Or having them to the master is not enough and there should be a new syslibrary version released?

@beringueb
Copy link
Collaborator Author

I don't think syslibrary has versions ? But yes the reason why the tests have failed is because it looks for the wrong version

@sgiardie
Copy link
Collaborator

yeah, I see in the repository that there is no released version... but I have this memory that syslibrary had to be released in order for mflike to be pip installable... is that right @xgarrido ?

@xgarrido
Copy link
Collaborator

xgarrido commented Feb 21, 2024

syslibrary should push a new version to pypi and we should increase the requirement here

I'm still trying to understand the eval function but I guess we should also change the default values of theses parameters https://github.com/simonsobs/syslibrary/blob/master/syslibrary/syslib_mflike.py#L44 in syslibrary. Maybe we can also require no default values...

@beringueb
Copy link
Collaborator Author

I think the default are correct now "t" instead of "tt". I will check about pushing syslib to pypi.

@xgarrido
Copy link
Collaborator

Ok I was still looking to your previous PR and you've added this one simonsobs/syslibrary#18

We need syslibrary to be on pypi but it's already the case https://pypi.org/project/syslibrary/ So someone @beringueb , @mgerbino need to push a version 0.1.1 at least to pypi

@beringueb
Copy link
Collaborator Author

Martina wil take care of it tomorrow morning. I'll then bump the requirements in setup.py and we should be good to merge

Copy link
Collaborator

@xgarrido xgarrido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are good to go.

@xgarrido xgarrido merged commit f37d2a7 into master Feb 21, 2024
12 checks passed
@xgarrido xgarrido deleted the fix_calibration branch February 21, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants