-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in calibration to reflect ones made in syslib #72
Conversation
Looks good but we should refer to the correct version of syslibrary. Did you push this before the modifications in syslibrary were merged to the master? Or having them to the master is not enough and there should be a new syslibrary version released? |
I don't think syslibrary has versions ? But yes the reason why the tests have failed is because it looks for the wrong version |
yeah, I see in the repository that there is no released version... but I have this memory that syslibrary had to be released in order for mflike to be pip installable... is that right @xgarrido ? |
I'm still trying to understand the |
I think the default are correct now "t" instead of "tt". I will check about pushing syslib to pypi. |
Ok I was still looking to your previous PR and you've added this one simonsobs/syslibrary#18 We need |
Martina wil take care of it tomorrow morning. I'll then bump the requirements in setup.py and we should be good to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are good to go.
Changing the keys to cal_pars to reflect the fact that they are a_lm (or map) level calibraation. This is now more consistent and makes with what has been changed to syslibrary here: simonsobs/syslibrary#17