Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cls with cells for pyccl #142

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

itrharrison
Copy link
Collaborator

Merging will close #141

@itrharrison itrharrison added the bug Something isn't working label Sep 22, 2023
@itrharrison itrharrison self-assigned this Sep 22, 2023
@itrharrison itrharrison linked an issue Sep 22, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Merging #142 (07da23e) into master (0fd50a0) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   77.78%   77.78%           
=======================================
  Files          31       31           
  Lines        1931     1931           
=======================================
  Hits         1502     1502           
  Misses        429      429           
Files Changed Coverage Δ
soliket/cross_correlation/cross_correlation.py 80.95% <100.00%> (ø)

Copy link
Collaborator

@mgerbino mgerbino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look great to me and solve the compatibility issue.

@itrharrison itrharrison merged commit 6bab0b8 into master Sep 22, 2023
7 checks passed
mgerbino pushed a commit that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compatability with pyccl
3 participants