Change relock block in satp3 policy so take_noise done while detector… #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in transition, relock automatically takes SC noise. Add re-definition of pysmurfs in det setup block so that UFMs that are re-introduced after failure will be biased.
| @@ -178,6 +175,7 @@ def make_blocks(master_file): | |||
| "################### Detector Setup######################", | |||
| "with disable_trace():", | |||
| " run.initialize()", | |||
| "pysmurfs = run.CLIENTS['smurf']", | |||
There was a problem hiding this comment.
This gets defined already at the top of the schedule in the preamble.
I jumped in to comment because I'm trying to eliminate the need for this direct access to the clients by adding functionality to sorunlib where needed. It'd be great to get a response to #110.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change relock block to take noise while detectors are in transition (don't zero bias), relock automatically takes SC noise so we will have a check on both. Add re-definition of pysmurfs in det setup block so that UFMs that are re-introduced after failure will be successfully biased.