Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pytest-docker-compose with pytest-docker plugin #484

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

BrianJKoopman
Copy link
Member

@BrianJKoopman BrianJKoopman commented Jul 26, 2023

Description

This does as the title says and replaces the use of the pytest plugin pytest-docker-compose with the plugin pytest-docker.

The difference is that pytest-docker-compose only supports docker-compose v1, while pytest-docker supports v2.

Motivation and Context

This, together with #482 fixes recent issues with installing socs.

#482 introduces a pin of pyyaml (pyyaml>6.0.1) which pytest-docker-compose (which pins to pyyaml<6) is incompatible with.

After seeing checks run, it turns out dropping this dependency completely fixes #478 without #482.

Fixes #478.

How Has This Been Tested?

I ran tests locally with this new plugin.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman marked this pull request as ready for review July 26, 2023 17:59
@BrianJKoopman BrianJKoopman merged commit b83db53 into main Jul 26, 2023
@BrianJKoopman BrianJKoopman deleted the koopman/replace-pytest-docker-compose branch July 26, 2023 18:40
@BrianJKoopman BrianJKoopman mentioned this pull request Jul 26, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs builds are failing
1 participant