Added Ethernet-exclusive connection functionality to Scpi_Psu Agent #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for Issue Request: "Support Keithley 2260B series PSU simonsobs#348"; Added new driver for Ethernet connections using socket library, also added logic-gates to initialization process, and print lines for debugging ease.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Hi @raymondllata -- apologies that this PR went unaddressed -- we were in the process of deploying our telescopes in the field and things were a bit hectic.
I'm not sure if you still have time to work on this, but also there is a very similar effort to implement Ethernet comms with the PSU agent in #715.
Let me know how you'd like to move forward, and let me offer a much belated thanks for your efforts here!
|
Close as superseded by #715. Thanks again for the PR, and apologies it didn't get looked at sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Issue Request: "Support Keithley 2260B series PSU #348"; Added new driver for Ethernet connections using socket library, also added logic-gates to initialization process, and print lines for debugging ease.
Description
Added dual functionality to SCPI PSU Agent. If the agent is not given a "--gpib-slot" command in OCS's default.yaml file, the agent will interact via a LAN Interface instead of the GPIB/Prologix Interface. This means that if the Power Supply is plugged in via Ethernet, the "--gpib-slot" argument will need to be removed for the changes to take place. The LAN driver innately uses port 5025 as the default port (standard for Keysight instruments), but functionality to take in a port argument from default.yaml could be added (if it is convenient I would love to work on the issue myself).
Motivation and Context
This change solves open issue: Support Keithley 2260B series PSU #348
How Has This Been Tested?
Tested with a Keysight E36312A, only interfacing with a LAN cable. Removed argument from default.yaml and successfully connect and interfaced with the Power Supply.
Types of changes
Checklist: