Backwards compatibility and packet drop counters #647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of @ykyohei's branch to add packet drop book-keeping to the HWP encoder agent. The purpose of this is to add encoder packet versioning to remove tight coupling requirements between socs and sobonelib. Additionally, some changes were made to the way dropped packets were counted in order to get it to work on my test setup.
These changes correspond to this commit in the sobonelib branch: simonsobs/sobonelib@aeb7e85
Description
This PR does makes the following changes:
parse_counter_info
so that it takes a packet version, so it can still parse older versions of encoder packetscounter_queue
from an unnamed tuple of values to theEncoderPacket
dataclass. This allows us to be more flexible in what data is parsed from the incoming packet, and makes it so code does not rely on hardcoded tuple indexes.Motivation and Context
This was required for getting packet drop testing working on my local beaglebone setup. Backwards compatibility stuff is so that we don't accidentally break other HWP systems on socs update.
How Has This Been Tested?
This has been tested on my local beaglebone with a fixed "HWP frequency"