Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent for IFM KQ1001 continuous level sensor #762

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

swh76
Copy link
Contributor

@swh76 swh76 commented Sep 26, 2024

Description

Adds new agent for reading out an IFM KQ1001 continuous level sensor. Agent is basically a copy of the IFM SBN246 flowmeter agent.

Motivation and Context

I wrote this agent to be able to read out this sensor in the SLAC DR lab.

How Has This Been Tested?

Tested using local checkout of socs at SLAC using a KQ1001 sensor. Seems to be working!
A minor issue is that it at first I had 2x SBN246s and 1x KQ1001 reading out w/ separate agents through a single IFM AL1340 IOLink Master and was getting errors in the agent dockers when all three running (see #760 (comment)). I reduced this by reducing the Pacemaker cadence for this new agent from 1 Hz to 0.2 Hz and setting the Pacemaker quantize flag just for this new agent to False. The issue may be due to accessing each of the AL1340 ports via the web interface using 3x separate agents (so there's nothing to prevent collisions). The agents don't seem to crash on these errors, but may have to change the implementation of the AL1340 agent(s) if ever want to scale to a larger number of sensors.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change required a change to the documentation.
  • I have updated the documentation accordingly.

@swh76 swh76 added the enhancement New feature or request label Sep 26, 2024
@swh76 swh76 self-assigned this Sep 26, 2024
@BrianJKoopman BrianJKoopman added the new agent New OCS agent needs to be created label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new agent New OCS agent needs to be created
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants