Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check tasks to hwp-pmx #801

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Add check tasks to hwp-pmx #801

merged 4 commits into from
Feb 13, 2025

Conversation

ykyohei
Copy link
Contributor

@ykyohei ykyohei commented Dec 11, 2024

Add several check tasks to hwp-pmx agent

Description

Add task to check current/voltage setting and protection limit.
This is fixed once it's set, so I didn't include in the process.
This also includes other minor changes. Changed default protection limits, removed "check" in decollator because it's unnecessary.

Motivation and Context

New check tasks are necessary for making sure the pmx settings.

How Has This Been Tested?

Need to test -> Tested by daq-dev

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@ykyohei ykyohei marked this pull request as ready for review December 21, 2024 15:58
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies this took so long to get to. A couple of spots that docstrings need updating. And I'm wondering about the removal of checks. I agree the checks on parameters passed for the limits maybe are needed, but why drop the checks on actual current/voltage settings?

@BrianJKoopman BrianJKoopman self-requested a review February 13, 2025 19:44
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@BrianJKoopman BrianJKoopman merged commit c82f9f6 into main Feb 13, 2025
4 checks passed
@BrianJKoopman BrianJKoopman deleted the hwp-pmx branch February 13, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants