Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in building image of wiregrid_actuator #833

Merged
merged 3 commits into from
Feb 18, 2025
Merged

fix bug in building image of wiregrid_actuator #833

merged 3 commits into from
Feb 18, 2025

Conversation

sadachi5
Copy link
Contributor

Description

Modify docker/wiregrid_actuator/Dockerfile in installing gclib python library.

Motivation and Context

fix bug in building image of wiregrid_actuator

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sadachi5 sadachi5 mentioned this pull request Feb 14, 2025
Open
BrianJKoopman
BrianJKoopman approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix. I'm going to revert #830 here too.

@BrianJKoopman BrianJKoopman merged commit a166179 into main Feb 18, 2025
7 checks passed
@BrianJKoopman BrianJKoopman deleted the shadachi/fix_wiregrid_actuator branch February 18, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianJKoopman BrianJKoopman BrianJKoopman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sadachi5 @BrianJKoopman