Handle missing 'op_name' key in response

simonsobs · Oct 14, 2024 · 2568a7e · 2568a7e
1 parent c7a57b1
commit 2568a7e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/sorunlib/_internal.py b/src/sorunlib/_internal.py
@@ -42,7 +42,11 @@ def check_response(client, response):
             initial request or after completion) or the response has timed out.
 
     """
-    op = response.session['op_name']
+    try:
+        op = response.session['op_name']
+    except KeyError:
+        error = f"Unable to parse response from {client}:\n{str(response)}"
+        raise RuntimeError(error)
     instance = client.instance_id
 
     _check_error(client, response)

diff --git a/tests/test__internal.py b/tests/test__internal.py
@@ -25,12 +25,19 @@ def __init__(self):
         self.test_op = MagicMock()
 
 
+# Attempt to recreate https://github.com/simonsobs/sorunlib/issues/174
+malformed_session = create_session('test', success=False)
+malformed_session.pop('op_name')
+
 invalid_responses = [(MockClient(), OCSReply(ocs.TIMEOUT,
                                              'msg',
                                              create_session('test', success=True))),
                      (MockClient(), OCSReply(ocs.ERROR,
                                              'msg',
-                                             create_session('test', success=False)))]
+                                             create_session('test', success=False))),
+                     (MockClient(), OCSReply(ocs.ERROR,
+                                             'msg',
+                                             malformed_session))]
 
 valid_responses = [
     (MockClient(), OCSReply(ocs.OK, 'msg', create_session('test', success=True)))]