Fix issue creating SMuRF controller client list for single controllers #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check for if we've just got a single controller instance back from
_find_active_instances(), which was resulting in the error described in #153._find_active_instances()returns a single string when it only finds one of a given Agent type online, otherwise it returns a list. We were handling the instance of two or more SMuRFs and zero SMuRFs, but not one. This fixes that.I added a whole new mock client setup to test this. There might be some way to simplify this, but I'm not too concerned at the moment. If we need to add a third mock client setup we should figure that out.
Resolves #153.