Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boresight control #77

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Add boresight control #77

merged 2 commits into from
Aug 15, 2023

Conversation

BrianJKoopman
Copy link
Member

@BrianJKoopman BrianJKoopman commented Aug 8, 2023

This adds control of the SATP boresight via the ACU Agent's set_boresight() task.

I initially started to add this as a parameter in the existing acu.move_to() (see 7441c25), but after doing that decided it might be better to be a separate function (see 7441c25), since it's unique to the SATP.

Any thoughts on this construction definitely welcome.

Resolves #73.

@BrianJKoopman BrianJKoopman marked this pull request as draft August 8, 2023 18:00
@BrianJKoopman BrianJKoopman force-pushed the koopman/boresight-commands branch from 486d492 to 93bf614 Compare August 8, 2023 18:00
Copy link
Member

@mhasself mhasself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could go either way on this (allowing go_to to include a boresight=... kwarg vs. separate API call). Maybe both ways. What you have done is probably sufficient for early SATP stuff.

@BrianJKoopman BrianJKoopman marked this pull request as ready for review August 15, 2023 16:07
@BrianJKoopman BrianJKoopman merged commit a13e0ba into main Aug 15, 2023
@BrianJKoopman BrianJKoopman deleted the koopman/boresight-commands branch August 15, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement boresight commands for SAT
2 participants