Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass client to check_response for error messages #93

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

BrianJKoopman
Copy link
Member

Without this it is difficult to tell which agent the error originates from based on the error text alone. OCSReply does not include the source, so we inspect the client used to make the operation call.

Resolves #92.

Without this it is difficult to tell which agent the error originates from
based on the error text alone. OCSReply does not include the source, so we
inspect the client used to make the operation call.

Resolves #92.
Copy link
Member

@mhasself mhasself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I guess that's what it takes.

src/sorunlib/_internal.py Outdated Show resolved Hide resolved
@BrianJKoopman BrianJKoopman merged commit dbc0248 into main Nov 2, 2023
4 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/response-instance-id-tracking branch November 2, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report the specific agent that caused a crash when checking response
2 participants