Create wiregrid calibration module #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianJKoopman
force-pushed
the
koopman/wiregrid-commands
branch
from
7737140
to
36ddb73
Compare
BrianJKoopman
force-pushed
the
koopman/wiregrid-commands
branch
4 times, most recently
from
04096ec
to
bb8e1a6
Compare
BrianJKoopman
force-pushed
the
koopman/wiregrid-commands
branch
from
bb8e1a6
to
c1da0da
Compare
BrianJKoopman
force-pushed
the
koopman/wiregrid-commands
branch
from
c1da0da
to
bf14fcf
Compare
|
This is finally ready to go. @sadachi5, I don't think there should be any surprises here following our offline discussions. |
|
Going to rebase and merge this. We can update things as needed from there. |
Co-authored-by: Shunsuke Adachi <[email protected]>
BrianJKoopman
force-pushed
the
koopman/wiregrid-commands
branch
from
91c07de
to
e046ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the wiregrid calibration module, allowing for running a wiregrid calibration with the
run.wiregrid.calibrate()command.A few other commands are included, mostly to facilitate debugging, as they allow for command over individual actions taken during the
calibrate()function --eject(),insert(), androtate().I split most of the new, unrelated, features out to separate PRs (see #104 and #103), but one thing I didn't split out was the addition of
check_running(). I don't think I like the way I implemented this, but I don't want it to hold up getting the wiregrid module out, so I'll probably change that later.Resolves #97.