Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow url when hosted remotely #57

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

szczys
Copy link
Contributor

@szczys szczys commented Sep 21, 2024

When building for GitHub Pages hosting on a different repository, the
GitHub repo address needs to point to where the tests were run.

Add a github_tests_repo input that defaults to repository on which the action is run, instead of mapping to the github_repo
input. This should work automatically when a different host repo is used, and allow customization for any other needs.

An example of hosting remotely was also added to the README file.

Resolves #56
Resolves #55

When building for GitHub Pages hosting on a different repository, the
GitHub repo address needs to point to where the tests were run.

This commit adds a `github_tests_repo` input that defaults to repository
on which the action is run, instead of mapping to the `github_repo`
input. This should work automatically when a different host repo is
used, and allow customization for any other needs.

Signed-off-by: Mike Szczys <[email protected]>
Show how to change the host repository used when building the reports.

Signed-off-by: Mike Szczys <[email protected]>
@szczys
Copy link
Contributor Author

szczys commented Oct 2, 2024

@simple-elf would you be able to review this PR?

@baev
Copy link
Collaborator

baev commented Oct 2, 2024

I'll try to review tomorrow, ping me if I don't

@szczys
Copy link
Contributor Author

szczys commented Oct 9, 2024

Hello @baev, checking back to see if you have time for a review.

@baev baev merged commit a8d7257 into simple-elf:master Oct 14, 2024
1 check passed
@baev
Copy link
Collaborator

baev commented Oct 14, 2024

@szczys thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants