Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about attribute name format used in examples #266

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

cicnavi
Copy link
Collaborator

@cicnavi cicnavi commented Nov 6, 2024

Fixes #265

@CzNorbi would this suffice?

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.29%. Comparing base (73e54d5) to head (670a135).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #266      +/-   ##
============================================
+ Coverage     52.85%   53.29%   +0.43%     
  Complexity      984      984              
============================================
  Files           109      109              
  Lines          3585     3807     +222     
============================================
+ Hits           1895     2029     +134     
- Misses         1690     1778      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CzNorbi
Copy link

CzNorbi commented Nov 6, 2024

Yes. Thanks!

@cicnavi cicnavi merged commit 5039390 into master Nov 6, 2024
15 checks passed
@cicnavi cicnavi deleted the fix/attr-name-format-example branch November 6, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute Mapping Failure with Example Configuration – Only Works with OID Format
2 participants