-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to SSP UI #267
Move to SSP UI #267
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## wip-version-6 #267 +/- ##
===================================================
+ Coverage 43.33% 45.20% +1.86%
- Complexity 1343 1387 +44
===================================================
Files 143 143
Lines 5631 5876 +245
===================================================
+ Hits 2440 2656 +216
- Misses 3191 3220 +29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, @cicnavi !!
I think the Menu.php
, Menu\Item.php
and menu.twig
are eligible for porting to SSP-core, so they can be reused by other modules.
Cool! Thanks for quick feedback for now.. |
@tvdijen I know there are a lot of changes in this PR, but if you would take a look again, maybe you catch something... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really neat job @cicnavi ! I would not have done this any other way!
I've limited my review to the PHP src-files (left out tests and twig-templates)
Not related to this PR, but in general:
- You may want to consider adding PHP 8.4 to the testsuite now that it has been released last month.
- Also, I'm in the process of migrating all repositories from Psalm to PHPStan.
Great, thanks! |
Move OIDC module pages into standard SSP UI.
This PR starts with extending base SSP template for OIDC module pages. Also, some new admin pages are introduced, like overview of module config values related to OIDC and federation settings. The main horizontal menu is taken from
admin
module.