Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to SSP UI #267

Merged
merged 17 commits into from
Dec 5, 2024
Merged

Move to SSP UI #267

merged 17 commits into from
Dec 5, 2024

Conversation

cicnavi
Copy link
Collaborator

@cicnavi cicnavi commented Nov 14, 2024

Move OIDC module pages into standard SSP UI.

This PR starts with extending base SSP template for OIDC module pages. Also, some new admin pages are introduced, like overview of module config values related to OIDC and federation settings. The main horizontal menu is taken from admin module.

image

@cicnavi cicnavi requested a review from tvdijen November 14, 2024 12:25
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 78.29716% with 130 lines in your changes missing coverage. Please review.

Project coverage is 45.20%. Comparing base (d59b3d0) to head (372f959).
Report is 1 commits behind head on wip-version-6.

Files with missing lines Patch % Lines
src/Utils/Routes.php 0.00% 61 Missing ⚠️
src/ModuleConfig.php 53.33% 35 Missing ⚠️
src/Services/Container.php 0.00% 17 Missing ⚠️
...ntrollers/Federation/EntityStatementController.php 0.00% 7 Missing ⚠️
src/Services/DatabaseMigration.php 0.00% 4 Missing ⚠️
src/Factories/AuthSimpleFactory.php 0.00% 2 Missing ⚠️
src/Factories/FederationFactory.php 0.00% 1 Missing ⚠️
src/Factories/FormFactory.php 0.00% 1 Missing ⚠️
src/Factories/JwksFactory.php 0.00% 1 Missing ⚠️
src/Repositories/ClientRepository.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             wip-version-6     #267      +/-   ##
===================================================
+ Coverage            43.33%   45.20%   +1.86%     
- Complexity            1343     1387      +44     
===================================================
  Files                  143      143              
  Lines                 5631     5876     +245     
===================================================
+ Hits                  2440     2656     +216     
- Misses                3191     3220      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tvdijen tvdijen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @cicnavi !!

I think the Menu.php, Menu\Item.php and menu.twig are eligible for porting to SSP-core, so they can be reused by other modules.

@cicnavi
Copy link
Collaborator Author

cicnavi commented Nov 14, 2024

Cool! Thanks for quick feedback for now..

@cicnavi cicnavi changed the title WIP move to SSP UI Move to SSP UI Dec 4, 2024
@cicnavi cicnavi marked this pull request as ready for review December 4, 2024 15:35
@cicnavi cicnavi requested a review from tvdijen December 4, 2024 15:35
@cicnavi
Copy link
Collaborator Author

cicnavi commented Dec 4, 2024

@tvdijen I know there are a lot of changes in this PR, but if you would take a look again, maybe you catch something...

Copy link
Member

@tvdijen tvdijen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really neat job @cicnavi ! I would not have done this any other way!
I've limited my review to the PHP src-files (left out tests and twig-templates)

Not related to this PR, but in general:

  • You may want to consider adding PHP 8.4 to the testsuite now that it has been released last month.
  • Also, I'm in the process of migrating all repositories from Psalm to PHPStan.

@cicnavi
Copy link
Collaborator Author

cicnavi commented Dec 5, 2024

Great, thanks!
Ok, will add PHP 8.4 check in another PR.
I've added a TODO note about moving to PHPStan in upgrade doc, so will do at some point.

@cicnavi cicnavi merged commit 8c80c69 into wip-version-6 Dec 5, 2024
14 checks passed
@cicnavi cicnavi deleted the wip-version-6-federation branch December 5, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants