Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/getSessionid/getSessionId/g for consistency with documentation #439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

s/getSessionid/getSessionId/g for consistency with documentation #439

wants to merge 1 commit into from

Conversation

buu700
Copy link

@buu700 buu700 commented May 29, 2016

No description provided.

@xdumaine
Copy link
Contributor

I do prefer the corrected casing, though this would be a breaking change. @tgabi333 @fippo

@buu700
Copy link
Author

buu700 commented Jul 14, 2016

Should I update this to support both names so existing code isn't affected?

@tgabi333 tgabi333 added this to the next major version milestone Jul 15, 2016
@xdumaine xdumaine mentioned this pull request Oct 24, 2016
Closed
@xdumaine
Copy link
Contributor

xdumaine commented Jul 5, 2017

Eek. I should have pulled this in for 3.0.0

@buu700
Copy link
Author

buu700 commented Jul 5, 2017

lol, you could always merge it and bump the version to 4.0 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breakingchange
Projects
None yet
Milestone
next major version
Development

Successfully merging this pull request may close these issues.
3 participants
@buu700 @xdumaine @tgabi333