Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issue fix: replacing the cyhunspell package with a different package that maintains the same API #24

Closed
wants to merge 1 commit into from

Conversation

RazhanHameed
Copy link
Contributor

Cyhunspell is no longer maintained and cannot be easily built for recent versions of Python, which causes the installation of klpt to break. This pull request provides a quick fix by replacing cyhunspell with a more up-to-date, actively maintained version of the wrapper.
cHunSpell is another wrapper around Hunspell that has fewer dependencies and no build issues for Python 3.11 and 3.12. It maintains the same API as cython_hunspell, so there is no need for any change from the KLPT side. I have tested all the functions from the Stem module, and they all work fine with it.

Chunspell is a wrapper around Hunspell that has fewer dependencies and no build issues for Python 3.11 and 3.12. It maintains the same API, so it should work just fine with klpt
@sinaahmadi
Copy link
Owner

Thanks for your help, @Hrazhan. I didn't know about cHunSpell and have locally changed the toolkit to use spylls which required rewriting some parts. But I prefer your solution. I wish I had known about it! 😁

Bijî biram.

@sinaahmadi
Copy link
Owner

@Hrazhan I don't know if GitHub shows the deployment status but some checks were not successful. One of them is ModuleNotFoundError: No module named 'build_hunspell'.

@RazhanHameed
Copy link
Contributor Author

@Hrazhan I don't know if GitHub shows the deployment status but some checks were not successful. One of them is ModuleNotFoundError: No module named 'build_hunspell'.

Yeah, I saw the builds. They're not building for Python 3.7; most systems nowadays have Python 3.10 installed by default. The latest version is Python 3.13, so I don't think anyone will have Python 3.7.

@RazhanHameed
Copy link
Contributor Author

It has, in fact, reached its end of life.

https://www.python.org/downloads/release/python-3717/

@RazhanHameed
Copy link
Contributor Author

@sinaahmadi I removed version 3.7 from the GitHub Actions and added the most recent versions, but I made another PR 🫣. I meant to add it to this one.

@sinaahmadi sinaahmadi closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants