DEVEXP-462 numbers snippets #6
Conversation
JPPortier
requested review from
Dovchik,
650elx,
krogers0607 and
asein-sinch
as code owners
There was a problem hiding this comment.
From the name of the folder, I would have expected another action to configure the rented number. For instance, you are also providing the SMS config in the rent_any snippet.
Maybe you can add a second request (update) to set the Voice config ?
There was a problem hiding this comment.
Done; but will sync with doc.
Seems snippet become more than a simple snippet.
We could imagine something like:
rentAnysnippet: from this PR highlighting rent and configuration for SMS with a single requestrentsnippet: the 1st part of this snippet source to rent an available number returned by "list available"updatesnippet: the 2nd part of this snippet source to perform an update onto an already rented number
Will check with doc (@alex-sberna )
There was a problem hiding this comment.
Done.
According to last sync:
- rent_and_config become simply 'rent' (even if it contains configuration; the purpose of the snippet is to highlight a 'rent' action)
- a new 'update only' snippet is added
|
|
||
| ActiveNumberService activeNumbersService = numbersService.active(); | ||
|
|
||
| String phoneNumber = "YOUR_phone_number_to_be_rented"; |
There was a problem hiding this comment.
The phone number is already rented at this step
There was a problem hiding this comment.
Could be something like "YOUR_phone_number_to_be_updated"
There was a problem hiding this comment.
Right
Thank you.
Fixed
No description provided.