Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVEXP-468: use Versioned numbers v1 #8

Merged
merged 5 commits into from
Jul 16, 2024
Merged

DEVEXP-468: use Versioned numbers v1 #8

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ef0b5e
refactor (Numbers): Use Numbers v1()
JPPortier Jul 4, 2024
61b158f
ci: Stop script onto compilation error
JPPortier Jul 4, 2024
f8aab60
feature (Numbers): Use elegant functions
JPPortier Jul 9, 2024
9ce72e4
refactor: available/active classes moved to request/response package …
JPPortier Jul 10, 2024
25817a7
Merge pull request #9 from sinch/DEVEXP-468-use-numbers-elegant-funct…
JPPortier Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compile.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/sh

(cd snippets && mvn clean spotless:apply)
(cd snippets && ./compile.sh)
(cd snippets && mvn clean spotless:apply) || exit 1
(cd snippets && ./compile.sh) ||exit 1

6 changes: 1 addition & 5 deletions snippets/compile.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,5 @@ echo "Compiling snippets:"
for snippet in $SNIPPETS
do
echo " - Snippet: $snippet"
mvn compile -Dsnippet="$(dirname $snippet)"
if [ $? -ne 0 ]
then
exit $?
fi
mvn compile -Dsnippet="$(dirname $snippet)" || exit 1
done
18 changes: 9 additions & 9 deletions snippets/numbers/active_update/Snippet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package numbers;

import com.sinch.sdk.domains.numbers.ActiveNumberService;
import com.sinch.sdk.domains.numbers.NumbersService;
import com.sinch.sdk.domains.numbers.models.ActiveNumber;
import com.sinch.sdk.domains.numbers.models.requests.ActiveNumberUpdateRequestParameters;
import com.sinch.sdk.domains.numbers.models.requests.ActiveNumberUpdateVoiceConfigurationRequestParameters;
import com.sinch.sdk.domains.numbers.api.v1.ActiveNumberService;
import com.sinch.sdk.domains.numbers.api.v1.NumbersService;
import com.sinch.sdk.domains.numbers.models.v1.ActiveNumber;
import com.sinch.sdk.domains.numbers.models.v1.VoiceConfiguration;
import com.sinch.sdk.domains.numbers.models.v1.VoiceConfigurationRTC;
import com.sinch.sdk.domains.numbers.models.v1.active.request.ActiveNumberUpdateRequest;
import java.util.logging.Logger;

public class Snippet {
Expand All @@ -19,11 +20,10 @@ static void execute(NumbersService numbersService) {
String appId = "YOUR_app_id";
String displayName = "Updated from Sinch Java SDK";

ActiveNumberUpdateVoiceConfigurationRequestParameters voiceConfiguration =
ActiveNumberUpdateVoiceConfigurationRequestParameters.builder().setAppId(appId).build();
VoiceConfiguration voiceConfiguration = VoiceConfigurationRTC.builder().setAppId(appId).build();

ActiveNumberUpdateRequestParameters updateRequest =
ActiveNumberUpdateRequestParameters.builder()
ActiveNumberUpdateRequest updateRequest =
ActiveNumberUpdateRequest.builder()
.setDisplayName(displayName)
.setVoiceConfiguration(voiceConfiguration)
.build();
Expand Down
13 changes: 7 additions & 6 deletions snippets/numbers/available_list/Snippet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
package numbers;

import com.sinch.sdk.domains.numbers.*;
import com.sinch.sdk.domains.numbers.models.*;
import com.sinch.sdk.domains.numbers.models.requests.*;
import com.sinch.sdk.domains.numbers.models.responses.AvailableNumberListResponse;
import com.sinch.sdk.domains.numbers.api.v1.AvailableNumberService;
import com.sinch.sdk.domains.numbers.api.v1.NumbersService;
import com.sinch.sdk.domains.numbers.models.v1.NumberType;
import com.sinch.sdk.domains.numbers.models.v1.available.request.AvailableNumberListRequest;
import com.sinch.sdk.domains.numbers.models.v1.available.response.AvailableNumberListResponse;
import java.util.logging.Logger;

public class Snippet {
Expand All @@ -17,8 +18,8 @@ static void execute(NumbersService numbersService) {
String regionCode = "US";
NumberType type = NumberType.LOCAL;

AvailableNumberListAllRequestParameters parameters =
AvailableNumberListAllRequestParameters.builder()
AvailableNumberListRequest parameters =
AvailableNumberListRequest.builder()
.setRegionCode(regionCode)
.setType(type)
.build();
Expand Down
18 changes: 9 additions & 9 deletions snippets/numbers/rent/Snippet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
package numbers;

import com.sinch.sdk.domains.numbers.AvailableNumberService;
import com.sinch.sdk.domains.numbers.NumbersService;
import com.sinch.sdk.domains.numbers.models.ActiveNumber;
import com.sinch.sdk.domains.numbers.models.requests.AvailableNumberRentRequestParameters;
import com.sinch.sdk.domains.numbers.models.requests.RentSMSConfigurationRequestParameters;
import com.sinch.sdk.domains.numbers.api.v1.AvailableNumberService;
import com.sinch.sdk.domains.numbers.api.v1.NumbersService;
import com.sinch.sdk.domains.numbers.models.v1.ActiveNumber;
import com.sinch.sdk.domains.numbers.models.v1.SmsConfiguration;
import com.sinch.sdk.domains.numbers.models.v1.available.request.AvailableNumberRentRequest;
import java.util.logging.Logger;

public class Snippet {
Expand All @@ -20,11 +20,11 @@ static void execute(NumbersService numbersService) {
String phoneNumber = "available_phone_number_to_be_rented";
String servicePlanId = "YOUR_service_plan_id";

RentSMSConfigurationRequestParameters smsConfiguration =
RentSMSConfigurationRequestParameters.builder().setServicePlanId(servicePlanId).build();
SmsConfiguration smsConfiguration =
SmsConfiguration.builder().setServicePlanId(servicePlanId).build();

AvailableNumberRentRequestParameters rentRequest =
AvailableNumberRentRequestParameters.builder()
AvailableNumberRentRequest rentRequest =
AvailableNumberRentRequest.builder()
.setSmsConfiguration(smsConfiguration)
.build();

Expand Down
18 changes: 9 additions & 9 deletions snippets/numbers/rent_any/Snippet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package numbers;

import com.sinch.sdk.domains.numbers.AvailableNumberService;
import com.sinch.sdk.domains.numbers.NumbersService;
import com.sinch.sdk.domains.numbers.models.ActiveNumber;
import com.sinch.sdk.domains.numbers.models.Capability;
import com.sinch.sdk.domains.numbers.models.NumberType;
import com.sinch.sdk.domains.numbers.models.requests.AvailableNumberRentAnyRequestParameters;
import com.sinch.sdk.domains.numbers.models.requests.RentSMSConfigurationRequestParameters;
import com.sinch.sdk.domains.numbers.api.v1.AvailableNumberService;
import com.sinch.sdk.domains.numbers.api.v1.NumbersService;
import com.sinch.sdk.domains.numbers.models.v1.ActiveNumber;
import com.sinch.sdk.domains.numbers.models.v1.Capability;
import com.sinch.sdk.domains.numbers.models.v1.NumberType;
import com.sinch.sdk.domains.numbers.models.v1.SmsConfiguration;
import com.sinch.sdk.domains.numbers.models.v1.available.request.AvailableNumberRentAnyRequest;
import java.util.Collections;
import java.util.logging.Logger;

Expand All @@ -26,12 +26,12 @@ static void execute(NumbersService numbersService) {

ActiveNumber response =
availableNumbersService.rentAny(
AvailableNumberRentAnyRequestParameters.builder()
AvailableNumberRentAnyRequest.builder()
.setCapabilities(Collections.singletonList(capability))
.setType(numberType)
.setRegionCode(regionCode)
.setSmsConfiguration(
RentSMSConfigurationRequestParameters.builder()
SmsConfiguration.builder()
.setServicePlanId(servicePlanId)
.build())
.build());
Expand Down
Loading