Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Add devtron in development mode #30

Closed
wants to merge 2 commits into from
Closed

Add devtron in development mode #30

wants to merge 2 commits into from

Conversation

JanMalch
Copy link

This PR adds the devtron extension in development mode.

@sindresorhus
Copy link
Owner

electron-debug already adds it if you add Devtron as a dev dependency: https://github.com/sindresorhus/electron-debug#activates-devtools-extensions However, that doesn't seem to work when nodeIntegration is off. I think it would be better to fix that in electron-debug first.

@JanMalch
Copy link
Author

Ah, I didn't see that, my bad.
I can look into electron-debug.

@JanMalch
Copy link
Author

JanMalch commented Dec 2, 2019

I added a preload.js to electron-debug (JanMalch/electron-debug@e2f4a56), which can be imported in the boilerplate's preload.js.

If this is a good solution I can extend the README accordingly.

@sindresorhus
Copy link
Owner

I was thinking reducing the boilerplate even more by taking advantage of https://electronjs.org/docs/api/session#sessetpreloadspreloads in electron-debug.

@reZach
Copy link

reZach commented Jan 14, 2020

@JanMalch, I've had no success in turning on Devtron in development branches in my personal projects, have you got Devtron working? A handful of people seem to think the project is already dead.

@sindresorhus
Copy link
Owner

How can we move this pull request forward?

@JanMalch
Copy link
Author

I also got the impression that it's dead and in the end I didn't use it either. I can take a look at it again in the next few days.

@sindresorhus
Copy link
Owner

Bump

@sindresorhus sindresorhus deleted the branch sindresorhus:master January 23, 2021 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants