Use persistent background pages #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, let's try it out. |
|
Did it fix it? The issue is still open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Chrome we had this long standing issue where the extension goes offline until you click on the extension icon (#132) or trigger background pages some other way. In some cases it goes completely unresponsive despite clicking on the extension icon (#220).
We haven't had similar issues on Firefox, which does not (yet) support non-persistent background pages, i.e., the background page stays loaded all the time.
https://developer.chrome.com/extensions/background_pages
Chrome suggests not to have resource intensive tasks in background pages, but all we have in background pages is an alarm, and a couple of network requests, so this should not be a problem.
I'm hoping changing to the same persistent model as Firefox on Chrome should fix issues mentioned above.
/cc @fregante and @sindresorhus for opinions.