TDL-20793: Improve Tap-Asana Reliability #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added missing tap-tester tests and assertions * resolved integration test failure * updated the code as per PEP8 standards * resolved pagination test failire * resolved test case fialure * upgraded the asana-python SDK and added missing fields * Revert "updated the code as per PEP8 standards" This reverts commit 8839e3a. * updated code as per PEP8 standards * added parameterized in config.yml file * updated all fields test case * reverted datatype update * upgraded asana SDK and singer-python version * - updated integration tests - removed pagination integration test * - removed pagination test * - fixed the review comments * TDL-20794: Upgrade SDK Version and add missing fields. (#48) * added the formats as date-format for the fields as per the documentation * schema fields addition * added few fields which are used as opt_fields * fixed all fields integration test --------- Co-authored-by: “rdeshmukh15” <[email protected]> Co-authored-by: RushiT0122 <[email protected]> --------- Co-authored-by: RushiT0122 <[email protected]> Co-authored-by: “rdeshmukh15” <[email protected]>
rdeshmukh15
changed the title
dsprayberry
reviewed
Feb 14, 2023
dsprayberry
reviewed
Feb 14, 2023
dsprayberry
reviewed
Feb 16, 2023
There was a problem hiding this comment.
I'm of the opinion that we should be merging the functional changes separately from the formatting changes. I don't want to block the deploy based on this so I'm not submitting a review that requests changes, but I also don't want to review the PR in this state.
I'd be happy to review a PR for purely functional changes if you open a distinct branch (without the formatting changes) and a new pull request.
kethan1122
reviewed
Feb 21, 2023
setup.py
Outdated
| @@ -10,8 +10,8 @@ | |||
| classifiers=["Programming Language :: Python :: 3 :: Only"], | |||
| py_modules=["tap_asana"], | |||
| install_requires=[ | |||
| "asana==0.10.2", | |||
| 'singer-python==5.12.2' | |||
| "asana==3.0.0", | |||
There was a problem hiding this comment.
Asana has released new SDK version 3.1.0. Should we bump it here ?
kethan1122
approved these changes
Feb 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps
Co-authored-by: “rdeshmukh15” [email protected]
Co-authored-by: RushiT0122 [email protected]