Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add support to the
custom_fields
field onTransaction
.Update the documentation to clarify the trailing days logic.
QUESTIONS BEFORE MERGING
custom_fields
is a "JSON" (key-value pairs). This is my first time playing with taps. What is the convention for such schemaless fields? Should I export it as a JSON as well, or as a string?Example:
{ "id": "tx_id", "custom_fields": { "a": "b" } }
vs.{ "id": "tx_id", "custom_fields": "{ \"a\": \"b\" }" }
Picking up the PR #19.
To address the issue #17.
Thanks @KAllan357 for the useful comment on #19 (comment). You were spot on right.
Manual QA steps
Risks
Rollback steps