Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed retry to check 2 completion criteria #194

Closed
wants to merge 1 commit into from
Closed

Changed retry to check 2 completion criteria #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tap_facebook/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,9 +668,10 @@ def run_job(self, params):
params=params,
is_async=True)
status = None
percent_complete = 0
time_start = time.time()
sleep_time = 10
while status != "Job Completed":
while status != "Job Completed" or percent_complete < 100:
duration = time.time() - time_start
job = AdsInsights.__api_get_with_retry(job)
status = job['async_status']
Expand All @@ -679,7 +680,7 @@ def run_job(self, params):
job_id = job['id']
LOGGER.info('%s, %d%% done', status, percent_complete)

if status == "Job Completed":
if status == "Job Completed" and percent_complete == 100:
return job

if duration > INSIGHTS_MAX_WAIT_TO_START_SECONDS and percent_complete == 0:
Expand Down