Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deposits.json #40

Open
wants to merge 1 commit into
base: TDL-13966-update-custom-fields
Choose a base branch
from

Conversation

talents10
Copy link

I propose pulling Classref (name and value) and Entity (name and value). These fields were included in a prior version of several of my Quickbooks integrations running on Stitch and I do not see them in the latest version. These are key fields for my internal software. If agreeable, please update as soon as possible so that these fields will flow through in Stitch. Many thanks.

Description of change

(write a short description or paste a link to JIRA)

Manual QA steps

Risks

Rollback steps

  • revert this branch

I propose pulling Classref (name and value) and Entity (name and value). These fields were included in a prior version of several of my Quickbooks integrations running on Stitch and I do not see them in the latest version. These are key fields for my internal software. If agreeable, please update as soon as possible so that these fields will flow through in Stitch. Many thanks.
@cmerrick
Copy link
Contributor

cmerrick commented Aug 6, 2021

Hi @talents10, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

cmerrick commented Aug 6, 2021

You did it @talents10!

Thank you for signing the Singer Contribution License Agreement.

@talents10
Copy link
Author

Ok, this has been signed. I am sort of new to this whole thing, so please make sure I used the correct syntax in the update I proposed. If my contribution is accepted, how quickly will it actually be implemented on the Stitch side? Also, if you agree with these changes, I will propose something similar for journal entries and purchases.

@talents10
Copy link
Author

It appears that these changes I proposed on class ref name and code and entity ref name and code were incorporated in the main branch. Can you let me know if I see that correctly and when the updates will flow through to my production Stitch tables so I can bring in these fields? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants