Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade aws-sdk from 2.814.0 -> 2.1404.0 #158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ralphsaunders
Copy link

We run Import Map Deployer in EKS and were trying to upgrade to v4.6.0 from the old version we were running (v2.2.1). When we upgraded we saw S3 permissions errors in the logs and import-map-deployer wasn't able to access buckets.

The yarn.lock specifies [email protected].

In the changelog for aws-sdk, there was a bugfix in 2.853.0 that should resolve this:

2.853.0

  • bugfix: s3: Bugfixing the s3 arn endpoint parser
    ...

This PR bumps the aws-sdk (and its dependency tree) to the latest v2 version.

$ yarn upgrade aws-sdk@^2
success Saved lockfile.
success Saved 13 new dependencies.
info Direct dependencies
└─ [email protected]
info All dependencies
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
└─ [email protected]
✨  Done in 7.81s.

success Saved lockfile.
success Saved 13 new dependencies.
info Direct dependencies
└─ [email protected]
info All dependencies
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
└─ [email protected]
✨  Done in 7.81s.
@ralphsaunders ralphsaunders marked this pull request as ready for review June 26, 2023 17:29
@ralphsaunders
Copy link
Author

Looks like someone else ran into this issue in #146 and suggested the same solution.

Unfortunately, deploying a custom image of this PR to our EKS this morning, we verified this didn't solve the issue.

We did have success with downgrading to import-map-deployer#v3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants