-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow setting of gitlab scope from env or settings file #435
allow setting of gitlab scope from env or settings file #435
Conversation
Looking good! Last item of action - please bump the version in https://github.com/singularityhub/sregistry/blob/master/VERSION and add a note to the CHANGELOG. If you'll be making a few PRs, we will put them all under this new version. |
@karcaw for linting, you can install pre-commit locally (and use our requirements.dev.txt to do so) and fix the errors sregistry/.github/workflows/main.yml Lines 21 to 29 in ee23901
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @karcaw !
This changes the default of SOCIAL_AUTH_GITLAB_SCOPE to the empty list, as well as allowing it to be set by the settings file or the env. Of note, the social login adds
read_user
to this list, which is enough for login, and as such the[]
default should be proper in most cases.This should fix #434
This Should fix #431
I also added a settings dumper that is useful for debugging, and shell scripts, which may help with #432