Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting of gitlab scope from env or settings file #435

Merged
merged 10 commits into from
Jun 9, 2023

Conversation

karcaw
Copy link
Contributor

@karcaw karcaw commented Jun 2, 2023

This changes the default of SOCIAL_AUTH_GITLAB_SCOPE to the empty list, as well as allowing it to be set by the settings file or the env. Of note, the social login adds read_user to this list, which is enough for login, and as such the [] default should be proper in most cases.

This should fix #434
This Should fix #431

I also added a settings dumper that is useful for debugging, and shell scripts, which may help with #432

@vsoch
Copy link
Member

vsoch commented Jun 6, 2023

Looking good! Last item of action - please bump the version in https://github.com/singularityhub/sregistry/blob/master/VERSION and add a note to the CHANGELOG. If you'll be making a few PRs, we will put them all under this new version.

karcaw pushed a commit to karcaw/sregistry that referenced this pull request Jun 6, 2023
@vsoch
Copy link
Member

vsoch commented Jun 6, 2023

@karcaw for linting, you can install pre-commit locally (and use our requirements.dev.txt to do so) and fix the errors

- name: Setup black linter
run: conda create --quiet --name black black
- name: Lint and format Python code
run: |
export PATH="/usr/share/miniconda/bin:$PATH"
source activate black
pip install -r .github/dev-requirements.txt
pre-commit run --all-files

Copy link
Member

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @karcaw !

@vsoch vsoch merged commit 41e4a65 into singularityhub:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hard coding SOCIAL_AUTH_GITLAB_SCOPE breaks auth. PLUGINS_ENABLED cannot be set in the settings.yaml file.
2 participants