-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor docker setup #134
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
It fails because there's no |
Okay, my mistake. Sorry |
I've pushed an image to |
requirements.txt
Outdated
@@ -2,7 +2,7 @@ | |||
# therefore they must be listed here. Moreover, they cannot be listed in | |||
# setup.py, as pip is not able to install them. | |||
http://github.com/Supervisor/supervisor/zipball/master#egg=supervisor==4.0.0.dev0 | |||
http://github.com/badochov/djsupervisor/zipball/master#egg=djsupervisor==0.4.0 | |||
http://github.com/LiquidPL/django-supervisor/zipball/master#egg=django-supervisor==0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to have this repo in sio2project organization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened a pull request to bring in my changes: sio2project/django-supervisor#1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've merged your PR to django-supervisor
I've switched django-supervisor to use the sio2project fork. I'm going to convert this PR to a draft for the time being, since at this moment it's not going to work, without the relevant sioworkers PR being merged, and the Docker images published. |
Apologies for not finishing up this pull request, I will get to it very soon. However, there's one problem, mainly that the I'm guessing it's just a matter of switching the package to be publicly available. |
Resolves #126.
This PR cleans up all the Docker and Docker Compose files used by oioioi.
Notable changes:
Dockerfile
to use multi-stage builds, now the resulting image doesn't have any leftovers from the build process,django-supervisor
to work with Python 3 properly, and fixed a bug which would sometimes cause it to break in virtualenvs, currently it's hosted in my fork at https://github.com/LiquidPL/django-supervisor, however I can move it to the sio2project org if it's preferred that way,apt
installed compilers,scripts/
directorydocker-compose-selenium.yml
Some additional things to consider:
extra/sample_configs/basic_settings_noserver.py
.