Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff as a linter with basic rules #213

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

maclick
Copy link
Member

@maclick maclick commented May 21, 2023

Created ruff configuration that uses these rules:

  • pycodestyle
  • pyflakes
  • isort

Also created github workflow for running ruff, as this is really light workflow, I've configured it to run on every push

@maclick maclick self-assigned this May 21, 2023
@maclick maclick requested a review from twalen as a code owner May 21, 2023 16:43
@metenn
Copy link
Contributor

metenn commented May 28, 2024

I don't know why nobody has commented on this yet, I think Ruff is a great step forward!
I can see Ruff was used to format the codebase within this PR already. Maybe it'd be better if the pass was done in a separate PR, or in a single, final commit, so this PR could be rebase-merged to keep future uses of git-blame more manageable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants