Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for changing the submission size limit #271

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

otargowski
Copy link
Contributor

I think that either this code or something that was used for XXVII OI's awesome "Pisarze" ("Writers") task should be upstreamed.
There might be more tasks that will need this in the future (I came across one recently) and imho SZKOpuł should support this too, since "Pisarze" are uploaded there.

This implementation allows for the submission size limit to be overriden in a problem package's config.
Validation had to be moved from the form fields to the form itself as the limit changes based on the chosen task.

@otargowski otargowski requested a review from twalen as a code owner September 29, 2023 12:39
Copy link
Contributor

@twalen twalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@twalen twalen merged commit 0facd8f into sio2project:master Apr 3, 2024
1 check passed
@otargowski otargowski deleted the Submission-size-limit-PR branch April 7, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants