Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin package constraints #323

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dawidratynski
Copy link
Contributor

Add a way to automatically pin the newest compatible package versions using pip-compile based on already present package requirements. This significantly speeds up deployment time.

This approach could potentially be better in the long run, as bumping package versions won't require manually going through all packages to change requirements, which could be an issue if only very strict requirements are present.

Closes #292

@dawidratynski dawidratynski marked this pull request as ready for review January 24, 2024 15:48
@dawidratynski dawidratynski requested a review from twalen as a code owner January 24, 2024 15:48
@otargowski
Copy link
Contributor

Can't we somehow keep the not-pinned requirements in setup.py?
pip-compile supports generating from that.

Dockerfile Outdated Show resolved Hide resolved
@dawidratynski
Copy link
Contributor Author

Moved not-pinned requirements back to setup.py and recompiled requirements.

@Iteron-dev Iteron-dev self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package constraints in setup.py should be stricter
3 participants