Update Python version to 3.10 in Dockerfile & Github actions #434
Conversation
…oworkers from 1.5.3 to 1.5.3
# Conflicts: # requirements.txt
setup.py
Outdated
| @@ -64,7 +64,7 @@ | |||
| # Used in quizzes module for adding new quizzes. | |||
| "django-nested-admin>=4.0,<4.1", | |||
| # SIO2 dependencies: | |||
| "filetracker>=2.1,<3.0", | |||
| "filetracker[server]>=2.2.0,<3.0", | |||
There was a problem hiding this comment.
Is it really required to add filetracker[server] to setup.py requirements? Production code on Szkopul requires only client code, as filetracker server is running on another system. And installing with server dependencies in prod crashed because of some version conflicts. Couldn't it be handled like in Olaf's PR #433 ?
There was a problem hiding this comment.
Good point! I'll remove the [server] optional dependencies from setup.py and add them to the Dockerfile.
Dockerfile
Outdated
| @@ -54,7 +54,7 @@ USER oioioi | |||
| ENV PATH $PATH:/home/oioioi/.local/bin/ | |||
|
|
|||
| ENV BERKELEYDB_DIR /usr | |||
| RUN pip3 install --user psycopg2-binary==2.8.6 twisted uwsgi | |||
| RUN pip3 install --user psycopg2-binary==2.9.10 twisted uwsgi | |||
There was a problem hiding this comment.
Could you explain a bit why this version bump is required?
There was a problem hiding this comment.
Actually, this version bump isn't required. Initially, there was a plan to upgrade to Python 3.11, but on Python 3.10, psycopg 2.8.6 works well.
Resolve #418.