Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache run results #127

Merged
merged 18 commits into from
Sep 24, 2023
Merged

Cache run results #127

merged 18 commits into from
Sep 24, 2023

Conversation

MasloMaslane
Copy link
Member

I added caching test results. Also when checker is changed, all cached results are removed.

@MasloMaslane MasloMaslane self-assigned this Sep 22, 2023
@MasloMaslane
Copy link
Member Author

I added new function: when a file from extra_compilation_files changes, all solutions in the same language as the file are removed from cache

tonowak
tonowak approved these changes Sep 23, 2023
View reviewed changes
Copy link
Collaborator

@tonowak tonowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some small suggestions, merge after resolving them:

src/sinol_make/helpers/cache.py Outdated Show resolved Hide resolved
src/sinol_make/helpers/cache.py Outdated Show resolved Hide resolved
src/sinol_make/structs/status_structs.py Outdated Show resolved Hide resolved
@MasloMaslane MasloMaslane merged commit 11900e8 into main Sep 24, 2023
8 checks passed
@MasloMaslane MasloMaslane deleted the cache-run-results branch September 24, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonowak tonowak tonowak approved these changes

Assignees

@MasloMaslane MasloMaslane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasloMaslane @tonowak