Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After running sinol-make doc remove log files #140

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

MasloMaslane
Copy link
Member

Now after running sinol-make doc all compilation logs are removed, unless --logs flag is set. Closes #139

@MasloMaslane MasloMaslane requested a review from tonowak October 5, 2023 14:43
@MasloMaslane MasloMaslane self-assigned this Oct 5, 2023
@MasloMaslane MasloMaslane linked an issue Oct 5, 2023 that may be closed by this pull request
@tonowak
Copy link
Collaborator

tonowak commented Oct 6, 2023

What's the reasoning behind this? Why is it needed?

Having a lot of commandline flags is sometimes harmful, as because of it the user won't necessarily read the whole --help.

@MasloMaslane
Copy link
Member Author

Compiling latex generates a lot of log files and I think that usually they aren't useful for the user and they only clutter up the doc/ directory

@tonowak
Copy link
Collaborator

tonowak commented Oct 9, 2023

Maybe let's move them to a cache dir, so that if needed, the user can see them?

@MasloMaslane
Copy link
Member Author

Sure, I couldn't find flags on latex and dvipdf commands to specify logs dir, so after compilation they are moved to .cache/doc_logs

@MasloMaslane MasloMaslane merged commit 057ed32 into main Oct 9, 2023
8 checks passed
@MasloMaslane MasloMaslane deleted the 139-sinol-make-doc-should-clean branch October 9, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sinol-make doc should clean
2 participants