Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fsanitize for ingen and inwer #221

Closed
wants to merge 2 commits into from
Closed

Conversation

MasloMaslane
Copy link
Member

Some linux distros have vm.mmap_rnd_bits set by default to 32. This sometimes breaks address and UB sanitizers. A workaround for this is to set sudo sysctl vm.mmap_rnd_bits = 28, but we decided that we'd rather delete sanitizers for now. The code is not completely deleted, because in future a verify command will run ingen and inwer with proper warnings and those sanitizers enabled

@otargowski
Copy link
Contributor

I found that setting the stack limit with ulimit -s to some large value (I tried values from 1e3 to 3e7) instead of unlimited fixes the issue, assuming that we're talking about the same ASan error.
The traceback for me starts with the following:

==9508==Shadow memory range interleaves with an existing memory mapping. ASan cannot proceed correctly. ABORTING.
==9508==ASan shadow was supposed to be located in the [0x00007fff7000-0x10007fff7fff] range.
==9508==This might be related to ELF_ET_DYN_BASE change in Linux 4.12.
==9508==See https://github.com/google/sanitizers/issues/856 for possible workarounds.

@MasloMaslane
Copy link
Member Author

Yes, we are getting the same issue. We'll test if your fix works

@MasloMaslane
Copy link
Member Author

Unfortunately, this didn't fix the issue for everyone, only for some people. It seems that an only consistent way to fix this is to set vm.mmap_rnd_bits

@MasloMaslane
Copy link
Member Author

Sanitizers were changed in #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants