Autoupdate oiejq #222
Merged
Autoupdate oiejq #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otargowski
reviewed
Apr 15, 2024
otargowski
requested changes
Apr 18, 2024
There was a problem hiding this comment.
Firstly, maybe we could future-proof this somewhat and also account for updates to the oiejq script itself?
Comparing hashlib.md5(open(path,'rb').read()).hexdigest() agains a saved md5 checksum should suffice.
Secondly, when oiejq is updated the user sees the following:
`oiejq` in `~/.local/bin/` not found, installing now...
`oiejq` was successfully installed.
I think that this is a bit misleading and may confuse the user.
If we don't want to properly differentiate between installing and updating oiejq then I'd suggest outputting sth like
Up to date `oiejq` in `~/.local/bin/` not found, installing new version...
|
Does are good ideas, thanks |
otargowski
requested changes
Apr 19, 2024
otargowski
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.