Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error: Could not find module '@ember/string' on ember 6.1.0 #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amiarSlimane
Copy link

Description

This pull request addresses an issue where the module @ember/string could not be found in Ember 6.1.0.

Changes

  • package.json

    • Updated ember-auto-import from ^1.11.3 to ^2.10.0
    • Added @ember/string with version ^3.1.1
  • ember-try.js

    • Updated fastboot resolution from ^3.1.2 to ^4.1.5 in both embroiderSafe and embroiderOptimized configurations

Testing

  • Ensure that the application builds successfully with the updated dependencies.
  • Verify that the module @ember/string is correctly resolved and no longer causes errors in Ember 6.1.0.
  • Run existing test suites to verify that there are no regressions (versions prior to 2.24 are failing).

Copy link

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth this looks like the right kind of change 👍 If we could get an approval to run CI that would be great, if it passes it's probably worth merging and releasing

@maxfierke
Copy link
Collaborator

Sorry for the delay, kicked off a CI run -- I'm fairly out of the Ember world at this point, but happy to usher in a new release to keep things working

@amiarSlimane
Copy link
Author

I have started migrating this addon to V2 and i found that tooltip.js is deprecated https://www.npmjs.com/package/tooltip.js , is it a good idea to do a migration for it ?

@mansona
Copy link

mansona commented Feb 11, 2025

@amiarSlimane its probably worth doing one and then the other, rather than doing both at the same time. i.e. v2 addon still with tooltip.js and then another later release migrating 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants