Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G-EnterFullRoom #101

Open
wants to merge 36 commits into
base: repo/1.5.2
Choose a base branch
from
Open

Conversation

HabboMaik
Copy link

@HabboMaik HabboMaik commented Jul 13, 2022

No description provided.

Copy link
Collaborator

@WiredSpast WiredSpast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The included zip file appears to be invalid as well

@@ -0,0 +1,17 @@
# G-EnterFullRoom
Copy link
Collaborator

@WiredSpast WiredSpast Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put any other files except the permitted/mandatory files into the folder.

Permitted/mandatory files:

  • extension.json (mandatory)
  • extension.zip (mandatory)
  • icon.png (permitted)
  • screenshot.png (permitted)

"version": "1.0",
"categories": ["Usability", "Others"],

"source": "https://github.com/HabboMaik/G-ExtensionStore/blob/repo/1.5.2/store/extensions/G-EnterFullRoom/",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source repository must be a repository with the open source code, not your own fork of the store repository (Same for the readme)


"source": "https://github.com/HabboMaik/G-ExtensionStore/blob/repo/1.5.2/store/extensions/G-EnterFullRoom/",
"readme": "https://github.com/HabboMaik/G-ExtensionStore/blob/repo/1.5.2/store/extensions/G-EnterFullRoom/README.md",
"releases": ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it if you're not adding a releases page

Comment on lines 26 to 35
"framework": {
"name": "Geode",
"version": "1.5"
},

"language": "Java",
"commands": {
"default": ["java", "-jar", "GClick.jar", "-c", "{cookie}", "-p", "{port}", "-f", "{filename}"],
"linux": ["(optional) <some OS-specific command...>"]
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The framework used is listed as Geode but the language is listed as Java, since Geode is a .NET language this isn't possible, also remove the linux command if it's not different from the default

Copy link
Author

@HabboMaik HabboMaik Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope its right after changes..

@HabboMaik HabboMaik requested a review from WiredSpast July 13, 2022 16:44

"source": "https://github.com/HabboMaik/G-EnterFullRoom",
"readme": "https://github.com/HabboMaik/G-EnterFullRoom/blob/main/README.md",
"releases": "https://github.com/HabboMaik/G-EnterFullRoom/releases/tag/v1.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm can you remove the /tag/v1.0? I think the releases field is meant to be non-version specific


"compatibility": {
"systems": ["Linux", "Windows", "Mac"],
"clients": ["Unity", "Flash"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're sure this one works for unity too?

@sirjonasxx
Copy link
Owner

https://github.com/HabboMaik/G-EnterFullRoom doesn't seem to be source code, but rather the executable files in the repository

store/extensions/G-EnterFullRoom/extension.json Outdated Show resolved Hide resolved
store/extensions/G-EnterFullRoom/extension.json Outdated Show resolved Hide resolved
Comment on lines 26 to 29
"framework": {
"name": "Geode",
"version": "1.5"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to my decompiler the Geode version which was used is 1.4.1.0 not 1.5

Suggested change
"framework": {
"name": "Geode",
"version": "1.5"
},
"framework": {
"name": "Geode",
"version": "1.4.1.0"
},

Comment on lines 37 to 38
"systems": ["Linux", "Windows", "Mac"],
"clients": ["Unity", "Flash"]
Copy link
Collaborator

@WiredSpast WiredSpast Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I now Geode extensions only work on Windows
Geode also only works for Flash (unless you specify the header ids yourself, but I don't think you did)

@WiredSpast
Copy link
Collaborator

One major other thing: The version of Geode you're using appears to be quite outdated, it doesn't take port, cookie and file arguments, these are required for the store

@HabboMaik
Copy link
Author

HabboMaik commented Jul 13, 2022

One major other thing: The version of Geode you're using appears to be quite outdated, it doesn't take port, cookie and file arguments, these are required for the store

@WiredSpast maybe you know how to update the Geode / can help me maybe?

@HabboMaik
Copy link
Author

You can find the dll of the latest release here: https://github.com/LilithRainbows/Geode/tree/main/Geode/bin/Release/net5.0

K, thank you. I changed the .dll file. I hope everything is fine now! :)

@WiredSpast
Copy link
Collaborator

Woops I made that reply on the wrong account

You can find the dll of the latest release here: https://github.com/LilithRainbows/Geode/tree/main/Geode/bin/Release/net5.0

K, thank you. I changed the .dll file. I hope everything is fine now! :)

Try running the extension, I doubt it will work right away since there have been some major changes in the mean time
(You will also have to update the zip file since it still contains the version with the old dll)

@HabboMaik
Copy link
Author

Woops I made that reply on the wrong account

You can find the dll of the latest release here: https://github.com/LilithRainbows/Geode/tree/main/Geode/bin/Release/net5.0

K, thank you. I changed the .dll file. I hope everything is fine now! :)

Try running the extension, I doubt it will work right away since there have been some major changes in the mean time (You will also have to update the zip file since it still contains the version with the old dll)

Oh yeah, it doesnt work anymore..
Tbh I can't change these things that are outdated.

But thanks for yall help! :\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants