-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G-EnterFullRoom #101
base: repo/1.5.2
Are you sure you want to change the base?
G-EnterFullRoom #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The included zip file appears to be invalid as well
@@ -0,0 +1,17 @@ | |||
# G-EnterFullRoom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't put any other files except the permitted/mandatory files into the folder.
Permitted/mandatory files:
- extension.json (mandatory)
- extension.zip (mandatory)
- icon.png (permitted)
- screenshot.png (permitted)
"version": "1.0", | ||
"categories": ["Usability", "Others"], | ||
|
||
"source": "https://github.com/HabboMaik/G-ExtensionStore/blob/repo/1.5.2/store/extensions/G-EnterFullRoom/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source repository must be a repository with the open source code, not your own fork of the store repository (Same for the readme
)
|
||
"source": "https://github.com/HabboMaik/G-ExtensionStore/blob/repo/1.5.2/store/extensions/G-EnterFullRoom/", | ||
"readme": "https://github.com/HabboMaik/G-ExtensionStore/blob/repo/1.5.2/store/extensions/G-EnterFullRoom/README.md", | ||
"releases": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it if you're not adding a releases page
"framework": { | ||
"name": "Geode", | ||
"version": "1.5" | ||
}, | ||
|
||
"language": "Java", | ||
"commands": { | ||
"default": ["java", "-jar", "GClick.jar", "-c", "{cookie}", "-p", "{port}", "-f", "{filename}"], | ||
"linux": ["(optional) <some OS-specific command...>"] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The framework used is listed as Geode but the language is listed as Java, since Geode is a .NET language this isn't possible, also remove the linux command if it's not different from the default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope its right after changes..
|
||
"source": "https://github.com/HabboMaik/G-EnterFullRoom", | ||
"readme": "https://github.com/HabboMaik/G-EnterFullRoom/blob/main/README.md", | ||
"releases": "https://github.com/HabboMaik/G-EnterFullRoom/releases/tag/v1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm can you remove the /tag/v1.0? I think the releases field is meant to be non-version specific
|
||
"compatibility": { | ||
"systems": ["Linux", "Windows", "Mac"], | ||
"clients": ["Unity", "Flash"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're sure this one works for unity too?
https://github.com/HabboMaik/G-EnterFullRoom doesn't seem to be source code, but rather the executable files in the repository |
"framework": { | ||
"name": "Geode", | ||
"version": "1.5" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to my decompiler the Geode version which was used is 1.4.1.0
not 1.5
"framework": { | |
"name": "Geode", | |
"version": "1.5" | |
}, | |
"framework": { | |
"name": "Geode", | |
"version": "1.4.1.0" | |
}, |
"systems": ["Linux", "Windows", "Mac"], | ||
"clients": ["Unity", "Flash"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I now Geode extensions only work on Windows
Geode also only works for Flash (unless you specify the header ids yourself, but I don't think you did)
One major other thing: The version of Geode you're using appears to be quite outdated, it doesn't take port, cookie and file arguments, these are required for the store |
Co-authored-by: WiredSpast <[email protected]>
Co-authored-by: WiredSpast <[email protected]>
@WiredSpast maybe you know how to update the Geode / can help me maybe? |
K, thank you. I changed the .dll file. I hope everything is fine now! :) |
Woops I made that reply on the wrong account
Try running the extension, I doubt it will work right away since there have been some major changes in the mean time |
Oh yeah, it doesnt work anymore.. But thanks for yall help! :\ |
No description provided.