1.21.3 port #246
Draft
1.21.3 port #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builds and runs, but rendering is completely borken; will need to look into renderlayers
|
it feels like all shader color applications are shifted by one? the background and tile layers get weirdly merged and consume the one meant for the markers, the tabs use the color of the last tab for the text and the color reset for the background, etc. i don't have nearly enough render stack experience to track this down. i slapped at the code for a few hours with no results |
sisby-folk
added
the
experimental hotfix
|
no luck with the render fixes, and to make matters worse, it doesn't work for 1.21.4 (tested on the release candidate) due to further if i return to this fork i'll probably move it to 1.21.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires sisby-folk/surveyor#58, but that pr also needs fixes (accesswidener needs to be readded, version needs to be bumped)
builds and runs, but rendering is currently broken
help would be appreciated!