Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tests #38

Open
wants to merge 5 commits into
base: devel
Choose a base branch
from
Open

Add new tests #38

wants to merge 5 commits into from

Conversation

addman2
Copy link
Collaborator

@addman2 addman2 commented May 7, 2023

New test added, catching problems we have on Leonardo.

@addman2 addman2 self-assigned this May 7, 2023
Copy link
Collaborator

@kousuke-nakano kousuke-nakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @addman2,

  • Would you also update jobcheck-serial.sh and -mpi.sh?
  • Do you think we should introduce the $IN argument to all the tests?

@addman2
Copy link
Collaborator Author

addman2 commented May 8, 2023

Hi @kousuke-nakano

I was not aware there are still jobchecks I will amend them as well.

About the parameter IN, yes it makes sense to introduce it to all scripts. However, I think these scripts have already too many parameters. Maybe it is better to change them to key-value pairs.

let me think a bit about it.

@addman2
Copy link
Collaborator Author

addman2 commented May 8, 2023

Dear @kousuke-nakano,

I changed one test (test_vmc/cm.test1.sh) into accepting key-value pair. My idea is to have these scripts with default values, and then CTest will override the ones necessary.

What do you think? Should I change all of them like this?

@kousuke-nakano
Copy link
Collaborator

Dear @addman2 Thanks for the update! let met think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants