fix lint and typecheck commands across monorepo

apps/docs/package.json

@@ -6,7 +6,9 @@
     "build": "storybook build -o build",
     "start": "serve build",
     "clean": "rm -rf .turbo && rm -rf node_modules",
-    "lint": "eslint ."
+    "lint": "eslint .",
+    "lint:fix": "pnpm lint --fix",
+    "typecheck": "tsc --noEmit"
   },
   "dependencies": {
     "@repo/ui": "workspace:*",

apps/nestjs/jest.config.js

@@ -11,9 +11,6 @@ module.exports = {
   testEnvironment: 'node',
   rootDir: './src',
   testRegex: '.*\\.spec\\.ts$',
-  transform: {
-    '^.+\\.(t|j)s$': 'ts-jest',
-  },
   collectCoverageFrom: ['**/*.(t|j)s'],
   coverageDirectory: './coverage',
 }

apps/nestjs/package.json

@@ -5,12 +5,15 @@
     "build": "nest build",
     "develop": "nest start --watch",
     "develop:debug": "nest start --debug --watch",
+    "lint": "eslint .",
+    "lint:fix": "pnpm lint --fix",
     "start": "node build/main",
     "test": "jest",
     "test:watch": "jest --watch",
     "test:cov": "jest --coverage",
     "test:debug": "node --inspect-brk -r tsconfig-paths/register -r ts-node/register node_modules/.bin/jest --runInBand",
-    "test:e2e": "jest --config ./test/jest-e2e.config.js"
+    "test:e2e": "jest --config ./test/jest-e2e.config.js",
+    "typecheck": "tsc --noEmit"
   },
   "dependencies": {
     "@nestjs/common": "^10.0.0",
@@ -23,11 +26,12 @@
     "rxjs": "^7.8.1"
   },
   "devDependencies": {
-    "@repo/eslint-config": "workspace:*",
-    "@repo/types": "workspace:*",
     "@nestjs/cli": "^10.0.0",
     "@nestjs/schematics": "^10.0.0",
     "@nestjs/testing": "^10.0.0",
+    "@repo/eslint-config": "workspace:*",
+    "@repo/tsconfig": "workspace:^",
+    "@repo/types": "workspace:*",
     "@types/express": "^4.17.17",
     "@types/jest": "^29.5.2",
     "@types/node": "^20.3.1",

apps/nestjs/src/app.controller.spec.ts

@@ -1,4 +1,5 @@
-import { Test, TestingModule } from '@nestjs/testing'
+import type { TestingModule } from '@nestjs/testing'
+import { Test } from '@nestjs/testing'
 
 import { AppController } from './app.controller'
 import { AppService } from './app.service'

apps/nestjs/src/app.controller.ts

@@ -1,6 +1,6 @@
 import { Controller, Get } from '@nestjs/common'
 
-import { AppService } from './app.service'
+import type { AppService } from './app.service'
 
 @Controller()
 export class AppController {

apps/nestjs/src/cats/cats.controller.spec.ts

@@ -1,8 +1,9 @@
-import { Test, TestingModule } from '@nestjs/testing'
+import type { TestingModule } from '@nestjs/testing'
+import { Test } from '@nestjs/testing'
 
 import { CatsController } from './cats.controller'
 import { CatsService } from './cats.service'
-import { CreateCatDto } from './dto/create-cat.dto'
+import type { CreateCatDto } from './dto/create-cat.dto'
 
 describe('Cats Controller', () => {
   let controller: CatsController
@@ -84,6 +85,7 @@ describe('Cats Controller', () => {
           age: 2,
         },
       ])
+
       expect(service.findAll).toHaveBeenCalled()
     })
   })

apps/nestjs/src/cats/cats.controller.ts

@@ -2,7 +2,7 @@ import { Body, Controller, Delete, Get, Param, Post } from '@nestjs/common'
 
 import { CatsService } from './cats.service'
 import { CreateCatDto } from './dto/create-cat.dto'
-import { Cat } from './schemas/cat.schema'
+import type { Cat } from './schemas/cat.schema'
 
 @Controller('cats')
 export class CatsController {
@@ -25,8 +25,6 @@ export class CatsController {
 
   @Delete(':id')
   async delete(@Param('id') id: string) {
-    console.log('id', id)
-
     return this.catsService.delete(id)
   }
 }

apps/nestjs/src/cats/cats.service.spec.ts

@@ -1,9 +1,10 @@
 import { getModelToken } from '@nestjs/mongoose'
-import { Test, TestingModule } from '@nestjs/testing'
-import { Model } from 'mongoose'
+import type { TestingModule } from '@nestjs/testing';
+import { Test } from '@nestjs/testing'
+import type { Model } from 'mongoose'
 
 import { CatsService } from './cats.service'
-import { Cat } from './schemas/cat.schema'
+import type { Cat } from './schemas/cat.schema'
 
 const mockCat = {
   name: 'Cat #1',

apps/nestjs/src/cats/cats.service.ts

@@ -2,7 +2,7 @@ import { Injectable } from '@nestjs/common'
 import { InjectModel } from '@nestjs/mongoose'
 import { Model } from 'mongoose'
 
-import { CreateCatDto } from './dto/create-cat.dto'
+import type { CreateCatDto } from './dto/create-cat.dto'
 import { Cat } from './schemas/cat.schema'
 
 @Injectable()

apps/nestjs/src/cats/schemas/cat.schema.ts

@@ -1,6 +1,6 @@
-import type { Cat as CatInterface } from '@repo/types'
 import { Prop, Schema, SchemaFactory } from '@nestjs/mongoose'
-import { HydratedDocument } from 'mongoose'
+import type { Cat as CatInterface } from '@repo/types'
+import type { HydratedDocument } from 'mongoose'
 
 export type CatDocument = HydratedDocument<Cat>
 

apps/nestjs/src/config/app.config.ts

@@ -1,6 +1,6 @@
 import { registerAs } from '@nestjs/config'
 
-export type AppConfig = {
+export interface AppConfig {
   env: 'development' | 'production' | 'test'
   port: number
 }

apps/nestjs/src/dogs/dogs.controller.spec.ts

@@ -1,4 +1,5 @@
-import { Test, TestingModule } from '@nestjs/testing'
+import type { TestingModule } from '@nestjs/testing';
+import { Test } from '@nestjs/testing'
 
 import { DogsController } from './dogs.controller'
 import { DogsService } from './dogs.service'

apps/nestjs/src/dogs/dogs.controller.ts

@@ -1,7 +1,7 @@
-import { Dog } from '@repo/types'
 import { Controller, Get } from '@nestjs/common'
+import type { Dog } from '@repo/types'
 
-import { DogsService } from './dogs.service'
+import type { DogsService } from './dogs.service'
 
 @Controller('dogs')
 export class DogsController {

apps/nestjs/src/dogs/dogs.service.spec.ts

@@ -1,4 +1,5 @@
-import { Test, TestingModule } from '@nestjs/testing'
+import type { TestingModule } from '@nestjs/testing';
+import { Test } from '@nestjs/testing'
 
 import { DogsService } from './dogs.service'
 

apps/nestjs/src/dogs/dogs.service.ts

@@ -1,5 +1,5 @@
-import { Dog } from '@repo/types'
 import { Injectable } from '@nestjs/common'
+import type { Dog } from '@repo/types'
 
 @Injectable()
 export class DogsService {

apps/nestjs/src/main.ts

@@ -8,12 +8,15 @@ async function bootstrap() {
   const logger = new Logger('NestApplication')
   const app = await NestFactory.create(AppModule)
   const configService = app.get(ConfigService)
-  const port = configService.get('app.port')
-  const host = configService.get('app.host')
+  const port = configService.get<string>('app.port')
+  const host = configService.get<string>('app.host')
 
   await app.listen(port, host)
 
   logger.log(`Nest application running on port ${port}`)
 }
 
-bootstrap()
+bootstrap().catch(error => {
+  console.error(error)
+  process.exit(1)
+})

apps/nestjs/test/dogs.e2e-spec.ts

@@ -1,5 +1,6 @@
-import { INestApplication } from '@nestjs/common'
-import { Test, TestingModule } from '@nestjs/testing'
+import type { INestApplication } from '@nestjs/common'
+import type { TestingModule } from '@nestjs/testing';
+import { Test } from '@nestjs/testing'
 import request from 'supertest'
 
 import { DogsModule } from '~/dogs/dogs.module'

apps/nestjs/tsconfig.json

@@ -1,21 +1,8 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "@repo/tsconfig/nest.json",
   "include": ["**/*.ts", "jest.config.js"],
+  "exclude": ["node_modules", "build"],
   "compilerOptions": {
-    "module": "commonjs",
-    "declaration": true,
-    "removeComments": true,
-    "emitDecoratorMetadata": true,
-    "experimentalDecorators": true,
-    "allowSyntheticDefaultImports": true,
-    "sourceMap": true,
-    "outDir": "./build",
-    "incremental": true,
-    "strictNullChecks": false,
-    "noImplicitAny": false,
-    "strictBindCallApply": false,
-    "noFallthroughCasesInSwitch": false,
-    "resolveJsonModule": true,
     "baseUrl": "./",
     "paths": {
       "~/*": ["./src/*"]

libs/eslint-config/_base.js

@@ -24,11 +24,21 @@ module.exports = {
     // Following rules are disabled during setup, but should probably be enabled later:
 
     // Errors as unknown, etc.
+    'no-console': 'off',
     '@typescript-eslint/no-explicit-any': 'off',
 
     // Some weird type issues when calling `catsApi` in Remix index route
     '@typescript-eslint/no-unsafe-assignment': 'off',
     '@typescript-eslint/no-unsafe-member-access': 'off',
     '@typescript-eslint/no-unsafe-call': 'off',
+
+    '@typescript-eslint/require-await': 'off',
+    '@typescript-eslint/no-unnecessary-condition': 'off',
+    '@typescript-eslint/no-extraneous-class': 'off',
+    '@typescript-eslint/unbound-method': 'off',
+    '@typescript-eslint/consistent-type-imports': 'off',
+    '@typescript-eslint/no-floating-promises': 'off',
+    '@typescript-eslint/no-unsafe-argument': 'off',
+    '@typescript-eslint/no-unsafe-return': 'off',
   },
 }

libs/eslint-config/nest.js

@@ -31,7 +31,7 @@ module.exports = {
     },
   },
   overrides: [
-    // Jest
+    // Jest configs
     {
       files: ['jest.config.js', 'jest-e2e.config.js'],
       rules: {

libs/tsconfig/nest.json

@@ -0,0 +1,22 @@
+{
+  "extends": "./base.json",
+  "$schema": "https://json.schemastore.org/tsconfig",
+  "display": "NestJS",
+  "compilerOptions": {
+    "module": "commonjs",
+    "declaration": true,
+    "removeComments": true,
+    "emitDecoratorMetadata": true,
+    "experimentalDecorators": true,
+    "allowSyntheticDefaultImports": true,
+    "sourceMap": true,
+    "outDir": "./build",
+    "incremental": true,
+    "strictNullChecks": false,
+    "noImplicitAny": false,
+    "strictBindCallApply": false,
+    "noFallthroughCasesInSwitch": false,
+    "resolveJsonModule": true,
+    "baseUrl": "."
+  }
+}

libs/types/index.ts

@@ -1,11 +1,11 @@
-export type Cat = {
+export interface Cat {
   _id: string
   name: string
   age: number
   breed: string
 }
 
-export type Dog = {
+export interface Dog {
   _id: string
   name: string
 }

libs/types/package.json

@@ -2,8 +2,14 @@
   "name": "@repo/types",
   "private": true,
   "main": "index.ts",
+  "scripts": {
+    "lint": "eslint .",
+    "lint:fix": "pnpm lint --fix",
+    "typecheck": "tsc --noEmit"
+  },
   "devDependencies": {
     "@repo/eslint-config": "workspace:*",
+    "@repo/tsconfig": "workspace:^",
     "typescript": "^5.3.2"
   }
 }

libs/types/tsconfig.json

@@ -0,0 +1,10 @@
+{
+  "extends": "@repo/tsconfig/base.json",
+  "include": ["."],
+  "exclude": ["dist", "node_modules"],
+  "compilerOptions": {
+    "lib": ["ES2015"],
+    "module": "CommonJS",
+    "outDir": "./dist"
+  }
+}

libs/ui/package.json

@@ -20,6 +20,7 @@
   "scripts": {
     "build": "tsup",
     "lint": "eslint .",
+    "lint:fix": "pnpm lint --fix",
     "develop": "tsup --watch",
     "typecheck": "tsc --noEmit"
   },

package.json

@@ -24,7 +24,7 @@
     "test": "pnpm -r test",
     "test:e2e": "pnpm -r test:e2e",
     "test:nestjs": "pnpm -F nestjs test",
-    "typecheck": "tsc -b ."
+    "typecheck": "turbo run typecheck"
   },
   "devDependencies": {
     "@flydotio/dockerfile": "^0.4.11",

turbo.json

@@ -5,7 +5,7 @@
       "dependsOn": ["^build"],
       // note: output globs are relative to each package's `package.json`
       // (and not the monorepo root)
-      "outputs": [".next/**", "!.next/cache/**"]
+      "outputs": [".next/**", "!.next/cache/**", ".cache"]
     },
     "deploy": {
       // A package's `deploy` script depends on the `build`,
@@ -21,11 +21,12 @@
       // either a `.tsx` or `.ts` file has changed in `src` or `test` folders.
       "inputs": ["src/**/*.tsx", "src/**/*.ts", "test/**/*.ts", "test/**/*.tsx"]
     },
-    // A package's `lint` script has no dependencies and
-    // can be run whenever. It also has no filesystem outputs.
     "lint": {
       "dependsOn": ["^build"]
     },
+    "typecheck": {
+      "dependsOn": ["^build"]
+    },
     "develop": {
       "dependsOn": ["build"],
       "cache": false,