Layouts Block: Prevent Double Page Builder when in Dev Mode #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1e29f03 resolve a timing issue with previews where the preview HTML won't display correctly. This has always been a potential issue but it's more pronounced due to the (intentional - it's a React Strict mode feature to help catch bugs) mount, unmount, and then remount that can occur when not in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents a single Layouts Block from rendering PB twice, preventing changes in "dev mode". This PR improves Layout Block unmounting so it also has positive knock-on effects outside of dev mode.
Dev mode requires at least the following added to wp-config.php:
define( 'WP_DEBUG', true );It may also require one of, or both of, the following (I get inconsistent results):