Fix wakelock bug - reacquire lock when refocusing tab #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current issue with wakelock is related to the wakelock releasing when changing tabs.
Then the wakelock is released.
And we never reacquire it.
This adds an event listener to document.visibilitystate and reacquires the lock when needed
This pr also moves the wakelock-code into a seperate WakeLockContext to avoid cluttering the datacontext code.
Not sure if this use of Context is "normal", but seems ok.
Ofc open to other suggestions, but i feel like this stuff should not be in DataContext at least.
Testing
Tested a lot with console.log on PC, seems to work.
Works on android phone.
Testing on this PC is a bit chaotic due to a minimum 5 minute screensaver, but i will try
Gifs
Added some gifs with a hacky overriding of the HR to display if wakelocked or not 🤠