Fix smart trainer disconnect issues #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix smart trainer disconnect issues by adding event listener that actually handles it
morteako
force-pushed
the
fix-reconnect-trainer
branch
from
f960ce1 to
7ba2162
Compare
sivertschou
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug that makes it impossible to reconnect (or connect to another) smart trainer after disconnect.
Current bug also does not show the trainer as disconnected even though it is
Real life user story
Avid cyclist morten calls sondre during a dundring session. Chrome is trolling morten by muting the messenger, and in desperation morten manages to somehow disable bluetooth. 🤡
This then cripples mortens dundring session. Because the trainer is disconnected, and there is no way to reconnect.
So morten has to download the current tcx, start a new dundring, reconnect hr and trainer, and start new session, and then combine the tcxs before uploading to strava.
Morten would like to avoid that 🤠
Current (buggy)
This pr (fixxy)
Previously implemented for HR : #226